Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add year property to End of Year analytics #3163

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

MiSikora
Copy link
Contributor

@MiSikora MiSikora commented Nov 4, 2024

Description

This PR adds year property to all End of Year analytics events.

Testing Instructions

Code review should be enough.

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@MiSikora MiSikora added [Type] Other Issues not covered by other types, such as refactoring and documentation. [Project] End of Year labels Nov 4, 2024
@MiSikora MiSikora added this to the 7.77 milestone Nov 4, 2024
@MiSikora MiSikora requested a review from a team as a code owner November 4, 2024 07:14
@MiSikora MiSikora requested review from geekygecko and removed request for a team November 4, 2024 07:14
@MiSikora MiSikora changed the title Add year property to Playback analytics Add year property to End of Year analytics Nov 4, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 4, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit94de965
Direct Downloadpocketcasts-app-prototype-build-pr3163-94de965.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit94de965
Direct Downloadpocketcasts-automotive-prototype-build-pr3163-94de965.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit94de965
Direct Downloadpocketcasts-wear-prototype-build-pr3163-94de965.apk

@geekygecko geekygecko merged commit 435a262 into main Nov 4, 2024
17 of 19 checks passed
@geekygecko geekygecko deleted the task/eoy-2024-year-analytics branch November 4, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Project] End of Year [Type] Other Issues not covered by other types, such as refactoring and documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants