Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project] Manage Downloaded Episodes - Display Modal when running on low storage and opening Storage & Data Use screen #3149

Merged
merged 8 commits into from
Nov 4, 2024

Conversation

mebarbosa
Copy link
Contributor

@mebarbosa mebarbosa commented Nov 1, 2024

Description

  • Displays the low storage modal when running on low storage and opening the Storage & Data Use screen
  • This PR does not implement the snooze for 7 days feature when taping on Maybe Later button
  • See: VvERCFIopLjFL8Fnczsf8r-fi-123_1167
  • Context: p1730298732804909/1730291928.354409-slack-C07TL9YK9V1

Fixes #3098

Testing Instructions

Modify the code bellow to always return true to make the tests faster. This will mock the low storage check

suspend fun isDeviceRunningOnLowStorage(statFs: StatFs = StatFs(Environment.getExternalStorageDirectory().path)): Boolean = withContext(Dispatchers.IO) {

  1. Download an episode
  2. Go to Profile -> Storage & Data Use
  3. ✅ Ensure the modal opens
  4. Tap on Maybe Later
  5. ✅ Ensure the modal dismiss
  6. Tap on Manage Downloads
  7. ✅ Ensure the Downloaded files screen opens

Screenshots or Screencast

Screen_recording_20241101_111721.webm
Screenshot_20241101_111138 Screenshot_20241101_111230 Screenshot_20241101_111253
light Screenshot_20241101_111057 Screenshot_20241101_111115

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@mebarbosa mebarbosa added this to the 7.77 milestone Nov 1, 2024
@mebarbosa mebarbosa requested a review from a team as a code owner November 1, 2024 14:33
@mebarbosa mebarbosa requested review from ashiagr and removed request for a team November 1, 2024 14:33
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 1, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commitf079ee2
Direct Downloadpocketcasts-app-prototype-build-pr3149-f079ee2.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commitf079ee2
Direct Downloadpocketcasts-automotive-prototype-build-pr3149-f079ee2.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commitf079ee2
Direct Downloadpocketcasts-wear-prototype-build-pr3149-f079ee2.apk

@mebarbosa mebarbosa force-pushed the task/add-low-storage-bottom-sheet branch from f2aa420 to 856d1e5 Compare November 1, 2024 15:13
@mebarbosa mebarbosa force-pushed the task/add-low-storage-bottom-sheet branch from 856d1e5 to 5baa18b Compare November 1, 2024 15:18
@mebarbosa mebarbosa force-pushed the task/add-low-storage-bottom-sheet branch from 8d6ed0f to bbbb0de Compare November 1, 2024 16:31
@ashiagr
Copy link
Contributor

ashiagr commented Nov 4, 2024

Looks great!

I just reran updateLintBaseline after uncommenting ignoreWarnings in build.gradle.

@ashiagr ashiagr merged commit 5701620 into main Nov 4, 2024
16 checks passed
@ashiagr ashiagr deleted the task/add-low-storage-bottom-sheet branch November 4, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project] Manage Downloaded Episodes - Display modal when running low storage in Storage Screen
3 participants