-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Project] Manage Downloaded Episodes - Display Modal when running on low storage and opening Storage & Data Use screen #3149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mebarbosa
added
[Type] Feature
Adding a new feature.
[Project] Manage Downloaded Episodes
labels
Nov 1, 2024
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
...es/settings/src/main/java/au/com/shiftyjelly/pocketcasts/settings/StorageSettingsFragment.kt
Fixed
Show fixed
Hide fixed
mebarbosa
force-pushed
the
task/add-low-storage-bottom-sheet
branch
from
November 1, 2024 15:13
f2aa420
to
856d1e5
Compare
mebarbosa
force-pushed
the
task/add-low-storage-bottom-sheet
branch
from
November 1, 2024 15:18
856d1e5
to
5baa18b
Compare
mebarbosa
force-pushed
the
task/add-low-storage-bottom-sheet
branch
from
November 1, 2024 16:31
8d6ed0f
to
bbbb0de
Compare
Looks great! I just reran |
ashiagr
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Maybe Later
buttonFixes #3098
Testing Instructions
Modify the code bellow to always return
true
to make the tests faster. This will mock the low storage checkpocket-casts-android/modules/services/utils/src/main/java/au/com/shiftyjelly/pocketcasts/utils/StorageUtil.kt
Line 11 in 565d4f7
Screenshots or Screencast
Screen_recording_20241101_111721.webm
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml
I have tested any UI changes...