Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Playback Settings - Enable remote FF #3147

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Nov 1, 2024

Description

This enables remote FF inside the app. It is still disabled in Firebase.

Fixes #3042

Testing Instructions

Code review should be sufficient.

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr added [Type] Other Issues not covered by other types, such as refactoring and documentation. [Project] Custom Playback Settings labels Nov 1, 2024
@ashiagr ashiagr added this to the 7.77 milestone Nov 1, 2024
@ashiagr ashiagr requested a review from a team as a code owner November 1, 2024 09:37
@ashiagr ashiagr requested review from mebarbosa and removed request for a team November 1, 2024 09:37
@ashiagr ashiagr changed the title Custom Playback Effects - Enable remote FF Custom Playback Settings - Enable remote FF Nov 1, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 1, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit443b885
Direct Downloadpocketcasts-app-prototype-build-pr3147-443b885.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit443b885
Direct Downloadpocketcasts-automotive-prototype-build-pr3147-443b885.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit443b885
Direct Downloadpocketcasts-wear-prototype-build-pr3147-443b885.apk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Project] Custom Playback Settings [Type] Other Issues not covered by other types, such as refactoring and documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Playback Settings
3 participants