Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Playback Settings: Update distinctUntilChanged condition for selecting effects tabs #3132

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Oct 30, 2024

Description

This updates distinctUntilChanged condition for effectsSettingsSegmentedTabBar to include global effects override state.

Testing Instructions

  1. Play an episode
  2. Open full-screen player
  3. Tap on effects view
  4. Change playback speed in "All podcasts" view
  5. Tap on "This podcast"
  6. ✅ Notice that "This podcast" tab is selected and displays playback effects for the selected podcast. If podcast playback effects were never changed, it should display 1x, off, off (p1730208229140779-slack-C07QMR40VV3)

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr added [Type] Other Issues not covered by other types, such as refactoring and documentation. [Project] Custom Playback Settings labels Oct 30, 2024
@ashiagr ashiagr added this to the Future milestone Oct 30, 2024
@ashiagr ashiagr requested a review from a team as a code owner October 30, 2024 08:18
@ashiagr ashiagr requested review from mebarbosa and removed request for a team October 30, 2024 08:18
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 30, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit8d8e502
Direct Downloadpocketcasts-app-prototype-build-pr3132-8d8e502.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit8d8e502
Direct Downloadpocketcasts-automotive-prototype-build-pr3132-8d8e502.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit8d8e502
Direct Downloadpocketcasts-wear-prototype-build-pr3132-8d8e502.apk

Copy link
Contributor

@mebarbosa mebarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! It's working as expected

@ashiagr ashiagr merged commit ef47996 into main Nov 1, 2024
17 of 19 checks passed
@ashiagr ashiagr deleted the task/3042-update-distinct-condition branch November 1, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Project] Custom Playback Settings [Type] Other Issues not covered by other types, such as refactoring and documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants