Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project] Up Next Shuffle - Display Unlock Dialog for Shuffle #3131

Closed
wants to merge 5 commits into from

Conversation

mebarbosa
Copy link
Contributor

@mebarbosa mebarbosa commented Oct 29, 2024

Description

  • This PR displays the unlock dialog when the user taps on shuffle icon if it's not paid user
  • Contex: p1730077568183099-slack-C07T08CTND9
  • Figma: KjyDLK1DPPg3snPBMVGWHw-fi-148_3551
  • The tracks will be added in [Project] Up Next Shuffle - Add Tracks for Unlock Shuffle Feature #3130
  • I asked here about the themes: p1730224482329139/1730077568.183099-slack-C07T08CTND9

Fixes #3128

Testing Instructions

  1. Run the App with free user
  2. Play an episode
  3. Open Up next
  4. ✅ Ensure you see up next shuffle painted as gold color
  5. Tap on shuffle icon
  6. ✅ Ensure the unlock dialog opens
  7. Tap on Not now
  8. ✅ Ensure the dialog is dismissed
  9. Open the dialog again
  10. Tap on Try plus now
  11. ✅ Ensure the paywall opens

Screenshots or Screencast

Screen_recording_20241029_163823.webm

image

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@mebarbosa mebarbosa added this to the 7.77 milestone Oct 29, 2024
@mebarbosa mebarbosa requested a review from a team as a code owner October 29, 2024 19:59
@mebarbosa mebarbosa requested review from geekygecko and removed request for a team October 29, 2024 19:59
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 29, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit35a2e45
Direct Downloadpocketcasts-app-prototype-build-pr3131-35a2e45.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit35a2e45
Direct Downloadpocketcasts-automotive-prototype-build-pr3131-35a2e45.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit35a2e45
Direct Downloadpocketcasts-wear-prototype-build-pr3131-35a2e45.apk

@dangermattic
Copy link
Collaborator

1 Error
🚫 This PR is tagged with do not merge label(s).

Generated by 🚫 Danger

@mebarbosa
Copy link
Contributor Author

Hey @geekygecko Just to let you know that we might have to close this PR because ours designs are thinking to remove this step. See this for context: p1730284572297509/1730077568.183099-slack-C07T08CTND9

I will let you know in case they change their mind

Base automatically changed from task/add-paywall-for-up-next-shuffle to main October 30, 2024 11:18
@mebarbosa mebarbosa linked an issue Oct 30, 2024 that may be closed by this pull request
@mebarbosa
Copy link
Contributor Author

Closing this PR since our designs decided to change the approach. Context here: p1730305046943719/1730077568.183099-slack-C07T08CTND9

@mebarbosa mebarbosa closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project] Up Next Shuffle - Display Paywall for free users
3 participants