Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project] Up Next Shuffle - Update Shuffle Button for Free users #3129

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

mebarbosa
Copy link
Contributor

@mebarbosa mebarbosa commented Oct 29, 2024

Description

  • This updates the shuffle button for free users
  • Context: p1730077568183099-slack-C07T08CTND9
  • I will display the paywall when tapping on shuffle button for free users in another PR
  • I asked here if we are going to use the same gold color for all themes: p1730220951890729/1730077568.183099-slack-C07T08CTND9

Fixes #3124

Testing Instructions

  1. Run the App with free user
  2. Play an episode
  3. Open Up next
  4. ✅ Ensure you see up next shuffle painted as gold color
  5. Log in with a plus user account
  6. ✅ Ensure you see up next shuffle is not painted with gold color

Screenshots or Screencast

dark-contrast dark extra-dark
dark-contrast dark extra-dark
indigo light-contrast light
indigo light-contrast light
Rose

|

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@mebarbosa mebarbosa added this to the 7.77 milestone Oct 29, 2024
@mebarbosa mebarbosa requested a review from a team as a code owner October 29, 2024 16:54
@mebarbosa mebarbosa requested review from ashiagr and removed request for a team October 29, 2024 16:54
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 29, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commitece5b5d
Direct Downloadpocketcasts-app-prototype-build-pr3129-ece5b5d.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commitece5b5d
Direct Downloadpocketcasts-automotive-prototype-build-pr3129-ece5b5d.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commitece5b5d
Direct Downloadpocketcasts-wear-prototype-build-pr3129-ece5b5d.apk

@ashiagr
Copy link
Contributor

ashiagr commented Oct 30, 2024

It would be good to differentiate between shuffle ON and OFF states for Free users similar to Plus users. If it makes sense, it could just be adding a dot below the icon.

up_next_shuffle_free_user.webm
up_next_shuffle_plus.webm

@mebarbosa
Copy link
Contributor Author

It would be good to differentiate between shuffle ON and OFF states for Free users similar to Plus users. If it makes sense, it could just be adding a dot below the icon.

up_next_shuffle_free_user.webm
up_next_shuffle_plus.webm

Hey @ashiagr Thanks for your suggestion! In my opinion, I think it would not make sense because for free users if they tap on this button, we display the paywall, so they don't have the ON state. See this PR #3131

But I can ask to the designs if you wanted

Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right 🤦‍♀️

@ashiagr ashiagr merged commit 668426d into main Oct 30, 2024
18 of 19 checks passed
@ashiagr ashiagr deleted the task/add-paywall-for-up-next-shuffle branch October 30, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project] Up Next Shuffle - Update shuffle icon for free users
3 participants