-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Project] Up Next Shuffle - Update Shuffle Button for Free users #3129
Conversation
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
...s/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/UpNextFragment.kt
Dismissed
Show dismissed
Hide dismissed
modules/services/images/src/main/res/drawable/shuffle_plus_feature_icon.xml
Dismissed
Show dismissed
Hide dismissed
It would be good to differentiate between shuffle ON and OFF states for Free users similar to Plus users. If it makes sense, it could just be adding a dot below the icon. up_next_shuffle_free_user.webmup_next_shuffle_plus.webm |
Hey @ashiagr Thanks for your suggestion! In my opinion, I think it would not make sense because for free users if they tap on this button, we display the paywall, so they don't have the ON state. See this PR #3131 But I can ask to the designs if you wanted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right 🤦♀️
Description
Fixes #3124
Testing Instructions
Screenshots or Screencast
|
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml
I have tested any UI changes...