Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Folders upsell flow to the podcast screen #3115

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Conversation

MiSikora
Copy link
Contributor

@MiSikora MiSikora commented Oct 28, 2024

Description

This PR adds Folders upsell flow to the Podcast screen. I also cleaned up the UI a touch by removing a redundant divider and removing a colored background form the button area.

Context: p1730075993721179-slack-C05RR9P9RAT

I'm not adding this to the changelog. I don't think it is worth it.

Testing Instructions

Note

Test this with the release variant on a device that is capable of doing test purchases.

  1. Open the app as an unsigned user.
  2. Subscribe to any podcast.
  3. You should see a folder icon with a lock.
  4. Tap on the icon.
  5. The upsell flow should start.
  6. Sign up using the flow.
  7. When it comes to payment cancel it.
  8. Go back to the podcast screen.
  9. Tap on the folder icon again.
  10. You should see the upsell screen.
  11. Make a purchase.
  12. Go back to the podcast screen.
  13. The button should now have a regular folder icon.
  14. Tap on it.
  15. You should see folder management screen.

Screenshots or Screencast

Flow

screen-20241028-114146.mp4

Upsell icon

Before After
header-before header-after

Screen cleanup

Before After
fol-bfore fol-after

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@MiSikora MiSikora added [Type] Enhancement Improve an existing feature. [Area] Folders labels Oct 28, 2024
@MiSikora MiSikora added this to the 7.76 milestone Oct 28, 2024
@MiSikora MiSikora requested a review from a team as a code owner October 28, 2024 10:56
@MiSikora MiSikora requested review from ashiagr and removed request for a team October 28, 2024 10:56
@MiSikora MiSikora changed the title Add Fodlers upsell to the podcast screen Add Folders upsell to the podcast screen Oct 28, 2024
@MiSikora MiSikora changed the title Add Folders upsell to the podcast screen Add Folders upsell flow to the podcast screen Oct 28, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 28, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit413967f
Direct Downloadpocketcasts-app-prototype-build-pr3115-413967f.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit413967f
Direct Downloadpocketcasts-automotive-prototype-build-pr3115-413967f.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit413967f
Direct Downloadpocketcasts-wear-prototype-build-pr3115-413967f.apk

@MiSikora MiSikora modified the milestones: 7.76, 7.77 Oct 28, 2024
@MiSikora MiSikora merged commit 9ee7d53 into main Oct 28, 2024
19 checks passed
@MiSikora MiSikora deleted the task/folder-upsell branch October 28, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Area] Folders [Type] Enhancement Improve an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants