-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Playback Settings: Add Feature Flag and add segmented tab bar #3065
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the component style and screenshots based on pdeCcb-7bh-p2#comment-5789. |
As the feature is behind FF, I'm merging this PR. I'll revisit it once we have further updates: pdeCcb-7bh-p2#comment-5804 |
Description
This adds the
custom_playback_settings
Feature Flag and the segmented tab bar in the playback effects view.** Ignore local files for now
Project #3042
Testing Instructions
** Only match the segmented control in Figma, the top header is highlighted only on iOS.
Screenshots or Screencast
Effects Settings
Plans
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml
I have tested any UI changes...