Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSL reference implementation uses non-standard "sheen" and "metal" closures? #9

Open
bhouston opened this issue Oct 21, 2019 · 1 comment

Comments

@bhouston
Copy link

bhouston commented Oct 21, 2019

Thanks for the reference OSL shader. It is quite nice except for one peculiarity.

It makes use of two closures "sheen" and "metal" that are non-standard OSL closures. We should probably state that in the OSL shader.

Maybe one should try to get "sheen" and "metal" accepted as part of the OSL standard shader specification?

They are not listed as part of the official OSL specification:
https://github.com/imageworks/OpenShadingLanguage/blob/master/src/doc/osl-languagespec.pdf

They are not supported by Blender's Cycles OSL:
https://docs.blender.org/manual/en/latest/render/shader_nodes/osl.html

It doesn't appear in the V-Ray's OSL support either:
https://docs.chaosgroup.com/display/VRAY3MAX/OSL+Support

Nor do they seem to be documented as supported by Arnold:
https://docs.arnoldrenderer.com/display/A5ARP/OSL+Shaders

Although I did find a hint they are supported by a version of Arnold according to this PR to MaterialX's Arnold OSL translation node: https://github.com/autodesk-forks/MaterialX/pull/420/files/aea870f3a33744c6f10c8c5e30768e0437beee08

@bhouston bhouston changed the title OSL reference implementation uses non-standard/undocumented "sheen" and "metal" closures? OSL reference implementation uses non-standard "sheen" and "metal" closures? Oct 21, 2019
@iliyang
Copy link
Contributor

iliyang commented Aug 7, 2020

Sorry for the late reply @bhouston, I missed this ticket. Indeed, Standard Surface can't be fully implemented in OSL without implementing the non-standard closures. We hope that (at least some of) those missing closures (or suitable alternatives) will be added to OSL soon, and we are making efforts to make that happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants