Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can exc.detail ever be a dict? #52

Open
stmudie opened this issue Sep 11, 2024 · 0 comments
Open

Can exc.detail ever be a dict? #52

stmudie opened this issue Sep 11, 2024 · 0 comments

Comments

@stmudie
Copy link
Member

stmudie commented Sep 11, 2024

@portrain

openday-scavenger/openday_scavenger/main.py

Line 86 in dac8ac4

detail = exc.detail if isinstance(exc.detail, str) else exc.detail.dict()

Static type checking says the exc.detail should only be a string. Was this check added for a reason?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stmudie