Added @available checks for new canvas keyboard and removed #Preview macro #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…view macro for xcode 14
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| } else { | ||
| Rectangle().foregroundColor(randomColors[Int(pitch.intValue) % 12]) | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| // activatedPitches: p, | ||
| // colorFunction: { x in Color(cgColor: PitchColor.helmholtz[Int(x.pitchClass)])} | ||
| // ).frame(width: 600, height: 100) | ||
| //} |
There was a problem hiding this comment.
Comment Spacing Violation: Prefer at least one space after slashes for comments. (comment_spacing)
| } | ||
|
|
||
| //MARK: - we can have preview macro after Xcode 15 is released | ||
| //#Preview { |
There was a problem hiding this comment.
Comment Spacing Violation: Prefer at least one space after slashes for comments. (comment_spacing)
| ).frame(width: 600, height: 100) | ||
| } | ||
|
|
||
| //MARK: - we can have preview macro after Xcode 15 is released |
There was a problem hiding this comment.
Comment Spacing Violation: Prefer at least one space after slashes for comments. (comment_spacing)
Mark Violation: MARK comment should be in valid format. e.g. '// MARK: ...' or '// MARK: - ...' (mark)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added these as I have a project that still needs iOS 14 and #Preview macro not live for Xcode 14 yet.