Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Doesn't show errors in files if flow strip_root setting is on #65

Open
Macil opened this issue Feb 17, 2016 · 4 comments
Open

Doesn't show errors in files if flow strip_root setting is on #65

Macil opened this issue Feb 17, 2016 · 4 comments

Comments

@Macil
Copy link

Macil commented Feb 17, 2016

If your .flowconfig file has strip_root=true in the [options] section, then linter-flow will only show squiggly lines under errors if the file has any unsaved changes.

(I'm not really clear what that setting is good for. Doesn't seem to make any difference in the output of manually running flow. Just found someone had turned it on in a project and I was confused as to why linter-flow was acting weird.)

@nmn
Copy link
Contributor

nmn commented Mar 22, 2016

related #78

@nmn
Copy link
Contributor

nmn commented Mar 22, 2016

Can you check what you get when you run flow status?

@Arcanemagus
Copy link
Member

Closing due to a lack of response. Please respond if you are still having issues in v5.5.0.

@Macil
Copy link
Author

Macil commented Aug 10, 2016

The bug still exists in v5.5.0. Adding strip_root=true to the [options] of a fresh or existing project reliably triggers it for me. Does it not for anyone else? I've attached a video in case I didn't describe it right: bug.zip.
flow and flow status don't have their output affected by the option.

test.js

/* @flow */

var x = y;

.flowconfig

[ignore]

[include]

[libs]

[options]
strip_root=true

Before adding the option

$ flow
test.js:3
  3: var x = y;
             ^ identifier `y`. Could not resolve name


Found 1 error

After adding the option


$ flow
test.js:3
  3: var x = y;
             ^ identifier `y`. Could not resolve name


Found 1 error
$ flow status

test.js:3
  3: var x = y;
             ^ identifier `y`. Could not resolve name


Found 1 error

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants