-
Notifications
You must be signed in to change notification settings - Fork 21
Should support use project local flow bin #166
Comments
Any updates on this? |
This is also reflected in the Flow install docs as a best practice: https://flow.org/en/docs/install/
|
I thought using local flow didn't work when I was looking into this yesterday, but it turns out that I had my linter package disabled. I'm using linter-flow 5.6.0, I set Hope that's useful to someone. |
It makes sense that that setting would work, but I don't feel it's very intuitive + the default assumption is a global install when that seems like it should be the special case (with the default to using I was looking at how AtomLinter/linter-eslint accomplishes using local vs global versions of the linting tool (though it seems I might be unaware of certain requirements specifically relating to flow running as a server) and it seems like some of that logic can be ported pretty readily. I would be a fan of a simpler solution to default to Hoping to submit a PR for this issue soon! |
For anyone else on Windows, you'll need to use backslashes instead of forward slashes ( |
I can't get the |
+1 for project specific "local". This is how linter-eslint works and so that should this very one also followed same pattern |
This is a rough first pass: #180 |
I use linter-flow without
npm i -g flow-bin
, and get error:I think linter-flow should support use project local flow bin as optional, for example use
<project root>/node_modules/.bin/flow
if it exists, so we can use the same version of flow bin for both Atom's linter-flow and commandnpm run flow
.The text was updated successfully, but these errors were encountered: