Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Relative path for better support for multiple projects #141

Open
note89 opened this issue Sep 28, 2016 · 3 comments
Open

Relative path for better support for multiple projects #141

note89 opened this issue Sep 28, 2016 · 3 comments

Comments

@note89
Copy link

note89 commented Sep 28, 2016

Hi i would like to use a relative path so that i can use
./node_modules/.bin/flow
in my projects.

executablePath: Absolute path to the Flow executable on your system.

From what i can see in it seems to be implemented. So maybe update the docs ?

@Arcanemagus
Copy link
Member

The path would be relative to where your .flowconfig file is found... which may not be the project root. I'm not sure I really want to note all the complexities that could be affecting that in a setting description.

If you want to write something up for just the readme though send in a PR and I'd be happy to review it 😉.

@ianwremmel
Copy link

As far as i can tell, the problem is that executablePath is not an absolute path, but in fact a relative path.

I think a fair bit of user pain could be saved by

  1. Changing the description of exectuablePath to "relative path to your project's .flowconfig to your flow executable
  2. Defaulting executablePath to node_modules/.bin/flow

I think this would also permanently solve the problem described in #134.

@Arcanemagus
Copy link
Member

As stated, if you want to submit a PR making those changes I can review + merge it.

Just a note, the text should be something like "An absolute path to `flow` or a relative path to `flow` from the project's `.flowconfig`."

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants