Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerrun.sh messes with permissions #7

Open
tomascohen opened this issue Aug 14, 2024 · 1 comment
Open

dockerrun.sh messes with permissions #7

tomascohen opened this issue Aug 14, 2024 · 1 comment

Comments

@tomascohen
Copy link
Contributor

We need to do it better.

There shouldn't be need to on the mounted code (to say the least) as it will bork the permissions/owner on the host OS.

In KTD we pass the running user ID and make sure commands don't change ownership in a way that could break things.

@tomascohen
Copy link
Contributor Author

I think the need to run setup_aspen_user_debian.sh is, on its own, a symptom of a design issue in the ADB stack. If you look closely to the actual Aspen image, you will notice that everything actually belongs to the www-data user.

In my opinion, the dockerrun.sh script should do what we do in KTD and just change the UID for www-data if needed. But not break the git clone with an otherwise unneeded chown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant