Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package music and sounds #2243

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cydyn
Copy link

@cydyn cydyn commented May 5, 2024

Fix issue: #2242
It will now properly add ClientIgnore to raw audio and music files, and will only download packages

@Arufonsu
Copy link
Contributor

Arufonsu commented Jul 22, 2024

okay

  • Do packed music/sounds work at all? and i mean, remove the non-packed music/sounds, and test if music/sounds actually play within the client - then provide us with a video showing this off.
  • There was a reason for music not being packed, pretty sure it was intentional from the authors/maintainers at some point, i just can't find that information anywhere at this point, this is why i'm asking you to test this out and provide us with a video of this feature actually fully working while it packs and plays the corresponding audio assets.

@cydyn
Copy link
Author

cydyn commented Jul 24, 2024

@Arufonsu Music is packaged and played correctly, and when downloading, only packages without raw music are downloaded.
Will try to send a video tomorrow how it works.

@Arufonsu Arufonsu added the question Project information is requested label Aug 8, 2024
@Arufonsu Arufonsu changed the title Fix: Package Music and Sounds fix: package music and sounds Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Project information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants