Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for http verbs #47

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add example for http verbs #47

wants to merge 2 commits into from

Conversation

ABDreos
Copy link
Collaborator

@ABDreos ABDreos commented Apr 26, 2024

No description provided.

@ABDreos ABDreos requested a review from egges April 26, 2024 14:21
@ABDreos ABDreos self-assigned this Apr 26, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For code examples that are not packages (which is most of our examples), poetry recently added an option we can set in the pyproject file under [tool.poetry]:

package-mode = false

Can you add this to pyproject files from now on if the example is not a package?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

Copy link
Contributor

@egges egges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there's a minor detail for the pyproject file, can you add that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants