Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppsFlyer Package via SPM is slow to resolve #294

Open
waitbutY opened this issue Jul 2, 2024 · 2 comments
Open

AppsFlyer Package via SPM is slow to resolve #294

waitbutY opened this issue Jul 2, 2024 · 2 comments
Labels

Comments

@waitbutY
Copy link

waitbutY commented Jul 2, 2024

Issue

In our app, we have 40-50 SPM dependencies, and AppsFlyer is in the top 3 slowest packages to resolve.

Potential Solution

This is a known SPM issue, as SPM by default pulls not just the code but all the branches and commit history, etc.
swiftlang/swift-package-manager#6062

Some larger repositories have solved this by creating a separate repo that just points to the precompiled XCFramework, resulting in much, much smaller and faster package resolution.

Example, Lottie: https://github.com/airbnb/lottie-spm

Can AppsFlyer SDK be offered in this way for iOS app consumption?

@amit-kremer93
Copy link
Contributor

Hi, did you followed this section in the readme?

@waitbutY
Copy link
Author

waitbutY commented Jul 3, 2024

ah @amit-kremer93 I saw that but didn't understand, it looks like -static is equivalent to what im asking for.

However, looks like my Appsflyer Framework is coming as a transitive dependency of segment-apps flyer-ios (https://github.com/AppsFlyerSDK/segment-appsflyer-ios), and that doesn't use the static/dynamic/strict addresses listed in the README, it just pulls in all of AppsFlyer I think (or maybe that is the same as the Dynamic option)

https://github.com/AppsFlyerSDK/segment-appsflyer-ios/blob/master/Package.swift

products: [
        // Products define the executables and libraries a package produces, and make them visible to other packages.
        .library(
            name: "segment-appsflyer-ios",
            targets: ["segment-appsflyer-ios"]),
    ],
    dependencies: [
        // Dependencies declare other packages that this package depends on.
        .package(name: "Segment", url: "https://github.com/segmentio/analytics-ios.git" , from: "4.0.0"),
        .package(name: "AppsFlyerLib" , url: "https://github.com/AppsFlyerSDK/AppsFlyerFramework.git", .exact("6.14.3")),
    ],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants