Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Locale Date Format for "Last Updated:" Date #1

Open
Mari023 opened this issue Nov 8, 2023 · 2 comments
Open

use Locale Date Format for "Last Updated:" Date #1

Mari023 opened this issue Nov 8, 2023 · 2 comments

Comments

@Mari023
Copy link

Mari023 commented Nov 8, 2023

It currently seems to be fixed to M/D/YYYY.
it should format according to the users locale (which would be DD.MM.YYYY for me (de_DE))

@Mari023
Copy link
Author

Mari023 commented Nov 8, 2023

looking at the code, it seems like it is already supposed to do that

<div>Last Updated: {lastUpdate.toLocaleDateString()}</div>

but it seems like it is evaluated at deployment time, and not on the users browser

@shartte
Copy link
Member

shartte commented Nov 8, 2023

looking at the code, it seems like it is already supposed to do that

<div>Last Updated: {lastUpdate.toLocaleDateString()}</div>

but it seems like it is evaluated at deployment time ,and not on the users browser

Hah you are right, that is a consequence of switching from purely client-side (Vite) to static-site (Next) and I simply forgot about this. Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants