Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swipe] Can we make MAGIC_NUMBER a parameter? #100

Open
agata-adamczewska-jt opened this issue Jul 25, 2023 · 2 comments
Open

[Swipe] Can we make MAGIC_NUMBER a parameter? #100

agata-adamczewska-jt opened this issue Jul 25, 2023 · 2 comments

Comments

@agata-adamczewska-jt
Copy link

Hi, I found a problem with using swipe gesture in the app I test. When I want to swipe-up the start point is located on the bottom button and minimise the app instead of swiping it. It is because the scrollable element has a full screen height, there is no smaller scrollable element on this page so I can't change it.
I found in the source code that there is a MAGIC_NUMBER which decides about the offset of the starting point from the element (in this case screen) edge. It is hardcoded to 49. If we could make it as a parameter, or at least decrease its value to 40, it would help me a lot. Do you think you could do this?

@dipakkumar1225
Copy link

Hi, I found a problem with using swipe gesture in the app I test. When I want to swipe-up the start point is located on the bottom button and minimise the app instead of swiping it. It is because the scrollable element has a full screen height, there is no smaller scrollable element on this page so I can't change it. I found in the source code that there is a MAGIC_NUMBER which decides about the offset of the starting point from the element (in this case screen) edge. It is hardcoded to 49. If we could make it as a parameter, or at least decrease its value to 40, it would help me a lot. Do you think you could do this?

yes, it will be good, if there is option to provide edge

@saikrishna321
Copy link
Member

We should definitely improve this to keep it more dynamic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants