Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] simplify environment settings #917

Open
ThanatosDi opened this issue Oct 22, 2024 · 2 comments
Open

[FR] simplify environment settings #917

ThanatosDi opened this issue Oct 22, 2024 · 2 comments

Comments

@ThanatosDi
Copy link
Contributor

ThanatosDi commented Oct 22, 2024

Are the domain of API_EXTERNAL_URL and the domain of GOTRUE OAuth2 necessarily the same?
maybe can simplify the oauth redirect url setting.

now I try to detaching the postgres settings. like host, port, username etc...

@ThanatosDi ThanatosDi changed the title [FR] Simplize environment settings [FR] simplify environment settings Oct 22, 2024
@khorshuheng
Copy link
Collaborator

Under normal circumstance, yes. It should be alright to use the same domain.

@wolfspyre
Copy link

After teasing this apart a bit, I don't think that an environment file is necessarily the wrong way to go here; with some love.

Something that I do think is needed here is a clear distillation of what should be set where and how.

This is one of the challenges that arise with multiple layers of abstraction points that has been faced in many config management tools...

when there's 5 different ways to adjust the sensitivity of a thing... and each of them work MOSTLY the same... it's initially not that big a deal to be somewhat cavalier about where things are declared and consumed....

But as you can see here... this quickly becomes akin to the scene in the wizard's apprentice ...

it's a bit unwieldy...

I think adopting a single env file that's added to each node declaration could go a long way towards reducing the confusion.

additionally, I think having the services emit a report of their config status somehow before starting may go a long way towards pointing people in the right direction when things are wonky.

(or maybe it does that already and I'm just blind)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants