Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install geth if geth --dev is used for testing #14

Open
fubuloubu opened this issue Jan 23, 2023 · 3 comments
Open

Install geth if geth --dev is used for testing #14

fubuloubu opened this issue Jan 23, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@fubuloubu
Copy link
Member

Using the geth plugin for testing won't function without geth binary present, so make sure we add this (and cache it) if we detect that plugin in use

Not as sure how to do this one because ape-geth is installed by default, a little deeper introspection needed to show that we are indeed using geth --dev within the test suite

@fubuloubu fubuloubu added the enhancement New feature or request label Jan 23, 2023
@antazoey antazoey changed the title Install geth if get --dev is used for testing Install geth if geth --dev is used for testing Jun 7, 2023
@antazoey
Copy link
Member

antazoey commented Jun 7, 2023

we could be clever, but it might be better to just have a use_geth: bool input.
it is only a small gotcha and keeps it simpler and more accurate

@antazoey
Copy link
Member

antazoey commented Jun 7, 2023

alternatively, to be more like the other provider issues here, we could force the user to put geth in the ape-plugins-listto get geth installed correctly.

@antazoey
Copy link
Member

we may want to close all of these as "wont do"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants