You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the documentation is wrong here.
If commitTime of T_1 < snapshotTime of T_2, the read in T_2 should return the value written in T_1, i.e. the incremented one.
This means that T_2 might need to wait till T_1 committed as indicated by the name of the test case.
We should add the comparison of times as an assert. Also, if possible, let's try to get rid of these sleeps, it seems to indicate that the tests are nondeterministic.
The original test is.... buggy.
The documentation of the test states
However, the testcase actually checks that the updated value is read.
This was different in the original version of the test: 0ad34d5
So maybe we introduced a bug and just changed the test case to fit it? The value was changed in 808170e#diff-af4a574965e2bea36840415849262ec4R179
Maybe someone with knowledge of the protocol (@bieniusa ?) can clarify this.
The text was updated successfully, but these errors were encountered: