Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0.2 -> main] Test fix: p2p_sync_throttle_test #862

Merged
merged 8 commits into from
Oct 2, 2024
Merged

[1.0.2 -> main] Test fix: p2p_sync_throttle_test #862

merged 8 commits into from
Oct 2, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Oct 1, 2024

Tweak p2p_sync_throttle_test test to be more reliable.
This backports main fixes to release/1.0 from #619. Mostly just gives the test more time to sync when syncing slowly.

Merges release/1.0 into main including #854 which was already in main.

Resolves #821

@heifner heifner added the OCI Work exclusive to OCI team label Oct 1, 2024
@heifner heifner linked an issue Oct 1, 2024 that may be closed by this pull request
Test failure: p2p_sync_throttle_test #821
Closed
@heifner heifner changed the base branch from merge_replay_with_ref_blockchain to main October 2, 2024 00:39
@ericpassmore ericpassmore added the test-instability tag issues for flaky tests, high priority to address label Oct 2, 2024
@ericpassmore
Copy link
Contributor

Note:start
category: Tests
component: P2P
summary: Fix sync throttle test for P2P.
Note:end

@heifner heifner merged commit 0379665 into main Oct 2, 2024
36 checks passed
@heifner heifner deleted the GH-821-test-fix-main branch October 2, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team test-instability tag issues for flaky tests, high priority to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure: p2p_sync_throttle_test
4 participants
@heifner @ericpassmore @greg7mdp @linh2931