[1.0.2] P2P: Resolve on reconnect - Take 2 #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
reviewed
Oct 1, 2024
greg7mdp
reviewed
Oct 1, 2024
| { | ||
| std::shared_lock g( connections_mtx ); | ||
| con = find_connection_i( host ); | ||
| } |
There was a problem hiding this comment.
Should we keep the lock until we are done using con?
There was a problem hiding this comment.
No. get_status grabs a different mutex. Safer to not hold both.
There was a problem hiding this comment.
So should we do the same here
spoonincode
reviewed
Oct 1, 2024
plugins/net_plugin/net_plugin.cpp
Outdated
| if (colon == std::string::npos || colon == 0) { | ||
| fc_elog( logger, "Invalid peer address. must be \"host:port[:<blk>|<trx>]\": ${p}", ("p", peer_address()) ); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
There seems to be a little duplication between this block and the split_host_port_type() below. I'm not sure it's worth trying to fix up though.
There was a problem hiding this comment.
That is a bit of a mess. I'll fix it up.
spoonincode
approved these changes
Oct 2, 2024
greg7mdp
approved these changes
Oct 2, 2024
This was referenced Oct 2, 2024
heifner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve address on reconnect. (Take 2, See #825)
Instead of:
Now you get:
This takes a different approach than #825. This approach is closer to Leap 4.0 approach to connection lifetime although it does keep the
connections_manageradded in Leap 5.0.Plan on backporting to Leap 5.0 once this is merged.
Resolves #525