Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.2 -> main] SHiP: Fix hang on exit #852

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Conversation

heifner
Copy link
Member

@heifner heifner commented Oct 1, 2024

This is a temporary fix until issue #842 can be worked. Some alternatives were attempted, but no simple fix could be found that didn't require more work toward #842 then desired for 1.0.x. See AntelopeIO/appbase#34

Test runs of a hacked up state_history_plugin with sleeps that caused it to hang on almost every CI/CD run.
Example failures: https://github.com/AntelopeIO/spring/actions/runs/11076070901
With this fix: https://github.com/AntelopeIO/spring/actions/runs/11124229769

Merges release/1.0 into main including #845

Resolves #822

@heifner heifner added the OCI Work exclusive to OCI team label Oct 1, 2024
@heifner heifner merged commit de91278 into main Oct 1, 2024
36 checks passed
@heifner heifner deleted the GH-822-ship-hang-main branch October 1, 2024 20:18
@ericpassmore ericpassmore added the bug The product is not working as was intended. label Oct 1, 2024
@ericpassmore
Copy link
Contributor

Note:start
category: Other
component: SHiP
summary: Fix hang on exit, draining references to SHiP found in io_service.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The product is not working as was intended. OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: ship_kill_client_test
4 participants