Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] Verify finality and QC extensions in Legacy and Transition blocks #697

Merged
merged 22 commits into from
Sep 5, 2024
Merged

[1.0] Verify finality and QC extensions in Legacy and Transition blocks #697

merged 22 commits into from
Sep 5, 2024

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Sep 4, 2024 •
edited
Loading

Currently verify_qc_claim is only called on Savanna blocks. On Legacy and Transitions blocks, we need to verify finality and QC extensions too.

Resolves #691

@linh2931 linh2931 mentioned this pull request Sep 4, 2024
Closed
heifner
heifner requested changes Sep 4, 2024
View reviewed changes
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
greg7mdp
greg7mdp requested changes Sep 4, 2024
View reviewed changes
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Show resolved Hide resolved
arhag
arhag requested changes Sep 4, 2024
View reviewed changes
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
greg7mdp
greg7mdp requested changes Sep 4, 2024
View reviewed changes
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
@arhag arhag linked an issue Sep 4, 2024 that may be closed by this pull request
Verify important block invariants (specifically in finality and QC extensions) for Legacy and Transition blocks #691
Closed
arhag
arhag requested changes Sep 4, 2024
View reviewed changes
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
greg7mdp
greg7mdp approved these changes Sep 5, 2024
View reviewed changes
libraries/chain/controller.cpp Show resolved Hide resolved
libraries/chain/controller.cpp Show resolved Hide resolved
arhag
arhag requested changes Sep 5, 2024
View reviewed changes
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: INTERNALS
summary: Refactor code to verify finality and QC extensions on Legacy and Transitions blocks, in addition to Savanna blocks.
Note:end

@linh2931 linh2931 merged commit c2b90f1 into release/1.0 Sep 5, 2024
36 checks passed
@linh2931 linh2931 deleted the legacy_qc_ext_checks branch September 5, 2024 02:35
@linh2931 linh2931 mentioned this pull request Sep 5, 2024
Merged
@ericpassmore
Copy link
Contributor

ericpassmore commented Sep 7, 2024 •
edited
Loading

Note:start
category: Other
component: Internal
summary: Refactor code to verify finality and QC extensions on Legacy and Transitions blocks, in addition to Savanna blocks.
Note:end

1 similar comment
@ericpassmore
Copy link
Contributor

Note:start
category: Other
component: Internal
summary: Refactor code to verify finality and QC extensions on Legacy and Transitions blocks, in addition to Savanna blocks.
Note:end

@ericpassmore ericpassmore added bug The product is not working as was intended. validation-protocol Change to the blockchain validation protocol. Impact full validation clients, not light clients. labels Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@heifner heifner heifner approved these changes

@arhag arhag arhag approved these changes

Assignees
No one assigned
Labels
bug The product is not working as was intended. validation-protocol Change to the blockchain validation protocol. Impact full validation clients, not light clients.
Projects
None yet
Milestone
No milestone
5 participants
@linh2931 @ericpassmore @greg7mdp @heifner @arhag