Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0 -> 1.0] treat a end_block_num=0 as "forever" in snapshot scheduler for compatibility with leap 4.0 behavior #571

Merged
merged 3 commits into from
Aug 19, 2024
Merged

[5.0 -> 1.0] treat a end_block_num=0 as "forever" in snapshot scheduler for compatibility with leap 4.0 behavior #571

merged 3 commits into from
Aug 19, 2024

Conversation

spoonincode
Copy link
Member

Merges AntelopeIO/leap#2402 in to 1.0, which resolved AntelopeIO/leap#2261

@spoonincode spoonincode linked an issue Aug 17, 2024 that may be closed by this pull request
Snapshot Scheduling Broken in 5.0.x AntelopeIO/leap#2261
Closed
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: CONFIG
summary: To keep compatibility with previous versions of Leap treat end block num=0 as forever in the snapshot scheduler.
Note:end

@spoonincode spoonincode merged commit 1ed540f into release/1.0 Aug 19, 2024
36 checks passed
@spoonincode spoonincode deleted the ss_end_block_num=0_10 branch August 19, 2024 17:03
@spoonincode spoonincode mentioned this pull request Aug 19, 2024
Merged
@arhag arhag added this to the Spring v1.0.0-rc2 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@heifner heifner heifner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Spring v1.0.0-rc2
Development

Successfully merging this pull request may close these issues.

Snapshot Scheduling Broken in 5.0.x
5 participants
@spoonincode @ericpassmore @greg7mdp @heifner @arhag