Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject p2p connections from nodes without support for active protocol features #611

Open
heifner opened this issue Aug 21, 2024 · 2 comments

Comments

@heifner
Copy link
Member

heifner commented Aug 21, 2024

Any Leap node connected to network when it activates Savanna will be hard-forked out. That Leap node will repeatedly request blocks from its peers because it will not be able to process received blocks.

After Savanna is activated (one proper Savanna block received), net_plugin could reject connections from net versions pre proto_savanna. Then the node would not waste time sending blocks to a node that can't process them.

@matthewdarwin
Copy link

jungle-dm12 - leap 5.0
jungle-trxrly173 - spring 1.0-rc2

from leap 5.0 side:

image

from spring 1.0 side:

image

@bhazzard
Copy link

bhazzard commented Sep 5, 2024

This should be generalized for future hard fork releases to the case where new protocol features are activated, rejecting p2p connections from nodes without those protocol features.

@bhazzard bhazzard added this to the Spring v2.0.0-cusp milestone Sep 5, 2024
@bhazzard bhazzard changed the title Reject P2P connections from leap after Savanna activated Reject p2p connections from nodes without support for active protocol features Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

4 participants