IF: Test: Transition to instant-finality with multiple producers #2224
Conversation
…-if-transition-test
…nstant-finality enabled. Fix activation timing of new proposer policy.
| setFinStr = f'{{"finalizer_policy": {{' | ||
| setFinStr += f' "threshold": {threshold}, ' | ||
| setFinStr += f' "finalizers": [' | ||
| finNum = 1 | ||
| for n in launcher.network.nodes.values(): | ||
| if n.index == Node.biosNodeId and not biosFinalizer: | ||
| for n in (self.nodes + [self.biosNode]): |
There was a problem hiding this comment.
Can this for loop be combined with the one above? They are in similar shape.
There was a problem hiding this comment.
I don't think so, need to have threshold calculated first.
tests/TestHarness/Cluster.py
Outdated
| @@ -1457,6 +1461,30 @@ def cleanup(self): | |||
| os.remove(f) | |||
|
|
|||
| # Create accounts, if account does not already exist, and validates that the last transaction is received on root node | |||
There was a problem hiding this comment.
This comment should be moved down. Add a new comment about setProds if needed.
tests/transition_to_if.py
Outdated
| Print(f'producing nodes: {pnodes}, topology: {topo}, delay between nodes launch: {delay} second{"s" if delay != 1 else ""}') | ||
|
|
||
| Print("Stand up cluster") | ||
| if args.plugin: |
There was a problem hiding this comment.
Will we ever test with extra plugins? If so, add the plugins to the test command in CMakeLists.txt.
| @@ -1044,6 +1045,7 @@ def activateInstantFinality(self, launcher, biosFinalizer, pnodes): | |||
| if not self.biosNode.waitForTransFinalization(transId, timeout=21*12*3): | |||
There was a problem hiding this comment.
So is the host function sent to the biosNode first even if biosFinalizer is false?
There was a problem hiding this comment.
Yes. Doesn't matter which node you look for the transaction on. Maybe we should rename this python method now. It has been there for a long time. It means is the transaction in a LIB block.
There was a problem hiding this comment.
We should change the name now as a part of the big changes for IF.
|
Note:start |
setprodsafter transition to instant-finalitysetprodsto activate new proposer policy at correct block (the first block of the producer)Resolves #1512