[4.0 -> main] SHiP: Improve startup when large number of SHiP logs in retain directory #1385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Startup of
state_history_plugin
was very slow when large number of SHiP logs were in theretain
directory. Almost all the performance slowness was due to use ofboost::flat_map
as it sorts and inserts into avector
on each insert. Changing to use astd::map
provides much more reasonable performance on startup. Also included in this PR are additional small performance improvements to the scanning of the log/indexs during startup. For my test case, improved from 76 seconds to 7 seconds.Merges
release/4.0
intomain
including #1384Resolves #1331