Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Fix failing test bls_sig_verif_string_multi #1531

Closed
Tracked by #1508
heifner opened this issue Aug 18, 2023 · 4 comments · Fixed by #1538
Closed
Tracked by #1508

IF: Fix failing test bls_sig_verif_string_multi #1531

heifner opened this issue Aug 18, 2023 · 4 comments · Fixed by #1538
Assignees
@systemzax
Labels
👍 lgtm

Comments

@heifner
Copy link
Member

heifner commented Aug 18, 2023 •
edited
Loading

libraries/libfc/test/test_bls.cpp
bls_sig_verif_string_multi
Failing in branch hotstuff_integration_main
@heifner heifner mentioned this issue Aug 18, 2023
Closed
@heifner heifner added 👍 lgtm and removed triage labels Aug 18, 2023
@arhag arhag added this to the Leap v5.0.0-rc1 milestone Aug 18, 2023
@heifner heifner mentioned this issue Aug 18, 2023
Merged
heifner added a commit that referenced this issue Aug 18, 2023
@heifner
GH-1533 Remove failing test since scheduled to be fixed by GH-1531
3b78eb9
@heifner heifner mentioned this issue Aug 18, 2023
Merged
@systemzax
Copy link
Member

This test can be safely ignored. It was intended to verify the prefix encoding, which we have now since removed.

@heifner
Copy link
Member Author

heifner commented Aug 21, 2023

The prefix encoding is still currently there. Will you be creating a PR to remove the test and prefix encoding?

@systemzax
Copy link
Member

Apologies, I had it removed in another branch that somehow didn't make its way into this one. Created a pull request here that takes care of this. It also has bls_private_key base58 encoding and an additional unit test for this. #1538

@heifner heifner linked a pull request Aug 22, 2023 that will close this issue
IF: Clean up of bls_private_key, bls_public_key and bls_signature, … #1538
Merged
@heifner
Copy link
Member Author

heifner commented Aug 29, 2023

Completed by #1538

@heifner heifner closed this as completed Aug 29, 2023
@arhag arhag removed this from the Leap v5.0.0-rc1 milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@systemzax systemzax

Labels
👍 lgtm
Projects
Team Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IF: Clean up of bls_private_key, bls_public_key and bls_signature, … AntelopeIO/leap
4 participants
@heifner @systemzax @arhag @enf-ci-bot