Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: Address abstraction leakage in HotStuff library #1518

Closed
Tracked by #1508
arhag opened this issue Aug 17, 2023 · 1 comment
Closed
Tracked by #1508

IF: Address abstraction leakage in HotStuff library #1518

arhag opened this issue Aug 17, 2023 · 1 comment
Assignees

Comments

@arhag
Copy link
Member

arhag commented Aug 17, 2023

Specifically:

  • fc::unsigned_int usage (which we reserve only for serialization)
  • On wire message struct passed throughout the code.
@heifner
Copy link
Member

heifner commented Aug 18, 2023

From @ericpassmore : chain_plugin.hpp is included in many places carrying hotstuff with it. When I look for the hs_* structures which also include chain_plugin.hpp I find three files net_plugin producer_plugin chain_plugin. An alternative would be having another header with the hotstuff structures and include the new header in the three files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants