Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-default options: help printed for nodeos --help #1446

Closed
spoonincode opened this issue Jul 25, 2023 · 0 comments · Fixed by #1447
Closed

Non-default options: help printed for nodeos --help #1446

spoonincode opened this issue Jul 25, 2023 · 0 comments · Fixed by #1447
Assignees
Labels
bug Something isn't working 👍 lgtm OCI Work exclusive to OCI team triage

Comments

@spoonincode
Copy link
Member

#1412 has a side effect where running nodeos --help now prints at the end of the output

info  2023-07-25T15:29:09.663 nodeos    main.cpp:153                  operator()           ] nodeos version v4.1.0-dev v4.1.0-dev-f9e6188892e9e9b5b5a41c380378a4f117f296f9-dirty
info  2023-07-25T15:29:09.663 nodeos    main.cpp:62                   log_non_default_opti ] Non-default options: help

This isn't strictly limited to --help, but also other commands like nodeos --print-default-config or even nodeos --version:

$ nodeos --version
v4.1.0-dev
info  2023-07-25T15:37:18.230 nodeos    main.cpp:153                  operator()           ] nodeos version v4.1.0-dev v4.1.0-dev-f9e6188892e9e9b5b5a41c380378a4f117f296f9-dirty
info  2023-07-25T15:37:18.230 nodeos    main.cpp:62                   log_non_default_opti ] Non-default options: version

imo this is confusing and annoying.

I even noticed it's printed during the build since apparently somewhere we now call nodeos --help during the build (which, alas, also breaks cross compiling..).

@heifner heifner added the bug Something isn't working label Jul 25, 2023
heifner added a commit that referenced this issue Jul 25, 2023
…tly asked for help,version,full-version,print-default-config
@heifner heifner self-assigned this Jul 25, 2023
@heifner heifner added the OCI Work exclusive to OCI team label Jul 25, 2023
heifner added a commit that referenced this issue Jul 26, 2023
Do not print version and non-default args for help
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 👍 lgtm OCI Work exclusive to OCI team triage
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants