Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Replay Opts by default if statehist plugin enabled #1403

Closed
eosusa opened this issue Jul 13, 2023 · 1 comment · Fixed by #1467
Closed

Disable Replay Opts by default if statehist plugin enabled #1403

eosusa opened this issue Jul 13, 2023 · 1 comment · Fixed by #1467
Assignees
Labels
👍 lgtm OCI Work exclusive to OCI team

Comments

@eosusa
Copy link

eosusa commented Jul 13, 2023

Currently, if you have the state history plugin enabled on the node, it requires the additional parameter of --disable-replay-opts to always be passed as an argument. If you don't pass the argument, the node just errors that it should be disabled. Can it be just added into the logic that if the statehist plugin is enabled that the "replay opts" are disabled automatically, which would help standardize not having to have the special param for statehist nodes (or forgetting to include it and having to relaunch)

@bhazzard
Copy link

Agreed.

Another problem is that --disable-replay-opts cannot be specified by config file, which makes this even worse.

The way it works today is silly, we should make these changes:

  • handle disabling replay opts implicitly when state history plugin is enabled
  • add disable replay opts as a config option

In the future, we should consider these sort of special cases being handled by designing around operational modes, either having special purpose executables or simple nodeos options that encapsulate the needs of the given operational mode.

@bhazzard bhazzard added 👍 lgtm and removed triage labels Jul 13, 2023
@heifner heifner self-assigned this Jul 27, 2023
@heifner heifner added the OCI Work exclusive to OCI team label Jul 27, 2023
@BenjaminGormanPMP BenjaminGormanPMP added this to the Leap v5.0.0-rc1 milestone Jul 27, 2023
heifner added a commit that referenced this issue Jul 28, 2023
heifner added a commit that referenced this issue Jul 29, 2023
heifner added a commit that referenced this issue Jul 31, 2023
SHiP: Auto disable-replay-opts instead of exiting with error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants