-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Replay Opts by default if statehist plugin enabled #1403
Comments
Agreed. Another problem is that --disable-replay-opts cannot be specified by config file, which makes this even worse. The way it works today is silly, we should make these changes:
In the future, we should consider these sort of special cases being handled by designing around operational modes, either having special purpose executables or simple nodeos options that encapsulate the needs of the given operational mode. |
… not actually needed for trace data.
SHiP: Auto disable-replay-opts instead of exiting with error
Currently, if you have the state history plugin enabled on the node, it requires the additional parameter of --disable-replay-opts to always be passed as an argument. If you don't pass the argument, the node just errors that it should be disabled. Can it be just added into the logic that if the statehist plugin is enabled that the "replay opts" are disabled automatically, which would help standardize not having to have the special param for statehist nodes (or forgetting to include it and having to relaunch)
The text was updated successfully, but these errors were encountered: