Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin_http_api_test.py always removes logs #1176

Closed
heifner opened this issue May 15, 2023 · 0 comments · Fixed by #1346
Closed

plugin_http_api_test.py always removes logs #1176

heifner opened this issue May 15, 2023 · 0 comments · Fixed by #1346
Assignees
@heifner
Labels
actionable bug Something isn't working 👍 lgtm OCI Work exclusive to OCI team tech debt
Milestone
Leap v5.0.0-rc1

Comments

@heifner
Copy link
Member

heifner commented May 15, 2023 •
edited by bhazzard
Loading

plugin_http_api_test.py always removes logs even when the test fails which makes it difficult to debug issues.

Provide an option to force keeping logs, with behavior defaulting to not keeping logs on pass and keeping logs on failure.
@heifner heifner added bug Something isn't working tech debt actionable and removed triage labels May 15, 2023
@vladtr vladtr self-assigned this Jun 21, 2023
@heifner heifner self-assigned this Jun 27, 2023
@heifner heifner added the OCI Work exclusive to OCI team label Jun 27, 2023
@heifner heifner added this to the Leap v5.0.0-rc1 milestone Jun 27, 2023
heifner added a commit that referenced this issue Jun 27, 2023
@heifner
GH-1176 Add --keep-logs option and do not clean logs on test failure
e4aeee1
@heifner heifner mentioned this issue Jun 27, 2023
Merged
heifner added a commit that referenced this issue Jun 27, 2023
@heifner
Merge pull request #1346 from AntelopeIO/GH-1176-test
1a92c80 
Test: plugin_http_api_test.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
actionable bug Something isn't working 👍 lgtm OCI Work exclusive to OCI team tech debt
Projects
Team Backlog
Archived in project
Milestone
Leap v5.0.0-rc1
Development

Successfully merging a pull request may close this issue.

Test: plugin_http_api_test.py AntelopeIO/leap
5 participants
@bhazzard @heifner @vladtr @enf-ci-bot @BenjaminGormanPMP