[4.0 -> main] merge up #233: remove is_callable_v<> workaround
#235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[4.0] remove `is_callable_v<>` workaround, fixing build on latest clang
heifner
approved these changes
Sep 26, 2023
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges up to main #233. Unfortunately I realized after preparing the merge that #194 already resolved this issue in a different way on
mainAfter some discussion with others, decided that matching the way this code is written in eos-vm currently (due to AntelopeIO/eos-vm#4) would be the best way to resolve the conflict since that will at least keep everything consistent.
Resolves #234