improve abi generation #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Sep 19, 2023
|
Please add a better PR description. |
|
@dimas1185 I'm sorry I don't know enough to review this. |
linh2931
approved these changes
Sep 22, 2023
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #225
after #201 we introduced a new logic where structure defined out of contract doesn't go to ABI.
There is an exception to that that is actively used by system contract. A lot of structures are defined out of contract but those have
[[eosio::contract("name")]]tag. That case was added to exceptions and also search of contract class was improved as in some cases inreference-contractsit was not found the old way. Also a fix added where structure that was defined out of contract was not properly defined in structures. That is reflected insingleton_contract.abiand corresponding test.Change Description
API Changes
Documentation Additions