Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct target for Type in ABI #198

Closed
ericpassmore opened this issue Jul 5, 2023 · 1 comment · Fixed by #201
Closed

Correct target for Type in ABI #198

ericpassmore opened this issue Jul 5, 2023 · 1 comment · Fixed by #201
Assignees
@dimas1185
Labels
bug Something isn't working 👍 lgtm triage
Milestone
CDT 4.0.0

Comments

@ericpassmore
Copy link
Contributor

CDT 4.0 had type included in wrong ABI. This is working in CDT 3.1
Correct
politics.abi.correct.txt
Incorrect
politics.abi.incorrect.txt

Info from Gnome:
this issue might be the root cause for the problem.

I essentially included an hpp file from a contract that defined a global singleton into a second contract, and cdt 4.0.0 incorrectly added the global table to the ABI (without adding the type definition). The correct behavior was to not include the global table definition (which was handled correctly in cdt 3.1.0)

Might be related to the changes they made in 4.0.0 regarding the naming of singleton tables
image
@ericpassmore ericpassmore added the bug Something isn't working label Jul 5, 2023
@BenjaminGormanPMP BenjaminGormanPMP added this to the CDT 4.0.0 milestone Jul 5, 2023
@ericpassmore
Copy link
Contributor Author

reproducible example provided https://github.com/CryptoMechanics/invalidabi/tree/main

@ericpassmore ericpassmore mentioned this issue Jul 10, 2023
Open
@aamirpashaa aamirpashaa mentioned this issue Jul 17, 2023
Closed
2 tasks
@dimas1185 dimas1185 mentioned this issue Jul 18, 2023
Merged
2 tasks
@ericpassmore ericpassmore mentioned this issue Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimas1185 dimas1185

Labels
bug Something isn't working 👍 lgtm triage
Projects
Team Backlog
Archived in project
Milestone
CDT 4.0.0
4 participants
@ericpassmore @dimas1185 @enf-ci-bot @BenjaminGormanPMP