Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Allow dunes to operate on arbitrarily named containers. #213

Open
ScottBailey opened this issue Jun 5, 2023 · 2 comments · May be fixed by #229
Open

Allow dunes to operate on arbitrarily named containers. #213

ScottBailey opened this issue Jun 5, 2023 · 2 comments · May be fixed by #229
Assignees
Labels
enhancement New feature or request 👍 lgtm

Comments

@ScottBailey
Copy link
Contributor

Currently, dunes only works with a container named dunes_contatiner. It would be nice to have CLI option to indicate the name of the container we want to operate on. Additionally, an option to set the image on start would be nice.

It would be okay if the container name option is -C, --container-name. And image name (only for --start-container) is --image-name.

It would be nice to do this:

dunes -C my_test_dunes --start-container --image-name dunes:1.2.0
dunes -C my_test_dunes --list
dunes --container-name my_test_dunes --stop-container

Additionally to do in this issue is evaluate all tests marked destructive and make them NON destructive by using a test container.

@ScottBailey
Copy link
Contributor Author

We will NOT want to modify tests/a100_generate_container_image_test.py since it tests the release functionality of bootstrap.py.

Note that bootstrap.py already takes --tag to safely generate an image with an arbitrary tag.

@ScottBailey
Copy link
Contributor Author

Much of the work is already done. This seems to be where the container and image name are set.

But we do need to evaluate this code to ensure that we download the correct image. Or no image at all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request 👍 lgtm
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants