Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to colpali-engine 0.3.x #21

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Bump to colpali-engine 0.3.x #21

merged 5 commits into from
Sep 23, 2024

Conversation

tonywu71
Copy link
Collaborator

Features

  • Bump to restructured colpali-engine 0.3.x
  • Remove the unused utils module
  • Various typing improvements in colpali.py

Tests

  • Bump to colpali-v1.2 in tests
  • Add guardrails and instructions in tests

Checklist

@tonywu71 tonywu71 mentioned this pull request Sep 17, 2024
3 tasks
@tonywu71 tonywu71 self-assigned this Sep 17, 2024
@tonywu71 tonywu71 force-pushed the bump-to-colpali-engine-0.3.x branch 2 times, most recently from 9bbb6eb to 5065d16 Compare September 17, 2024 12:20
@tonywu71
Copy link
Collaborator Author

@bclavie I've started to clean up tests but I'm a bit unsure about the test_add_to_index one, so I've marked it with skip for now! Otherwise, the other tests are passing! 👍🏼

Copy link
Contributor

@bclavie bclavie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much for doing it yourself!

@bclavie bclavie merged commit fd60959 into main Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants