Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resurrect this fantastic tool #97

Open
marcelstoer opened this issue Jun 25, 2024 · 14 comments
Open

Resurrect this fantastic tool #97

marcelstoer opened this issue Jun 25, 2024 · 14 comments

Comments

@marcelstoer
Copy link
Contributor

This a plea for @AndiDittrich & @serg3295 to join forces and to bring NodeMCU-Tool back to the spotlight one way or the other.

  • This project hasn't been updated in 3y.
  • The fork at https://github.com/serg3295/NodeMCU-Tool/ does not seem to publish to the NPM repository. Instead it points to the original's npmjs.com package.
  • The fork uses separate branches for up-to-date ESP32 support (e.g. auto and idf4).

I am sure the community would very much appreciate if the two of you could find a way to merge your efforts. Having a single NodeMCU-Tool project has lots of benefits for the community. Regardless of what comes out of this: thanks for what you've contributed so far!

@serg3295
Copy link
Contributor

Branches 'auto' and 'idf4' of the fork are outdated. The current branch is dev-esp32.

I have no plan to publish my fork in NPM repository, as I am not the author of this application.
I can make a PR of the 'dev-esp32' branch.

@marcelstoer
Copy link
Contributor Author

I can make a PR of the 'dev-esp32' branch.

I would certainly appreciate that. However, without commitment or interest from @AndiDittrich this would be in vain.

@AndiDittrich
Copy link
Owner

dear @marcelstoer ,

currently i've absolutely no time to maintain/enhance this project

@marcelstoer
Copy link
Contributor Author

Np, I know how that feels. @serg3295 did a great job making your tool compatible with current versions of the ESP32 releases (keeping the ESP8266 support as-is). The question is, would you be willing to accept his PR and push a new release to the NPM repository i.e. minimal effort?

@AndiDittrich
Copy link
Owner

"simple" is relative...merging requires some time...just took a quick look onto the branch

@serg3295
Copy link
Contributor

Hello, @AndiDittrich

I opened a PR that contains only 3 commits to facilitate reviewing. These are the minimum changes to support esp32xx chips

In this PR:

  • dependencies are not updated
  • esbuild is not added
  • warnings of [email protected] not fixed

I can add commits with major upgrade for glob, commander and update dependencies if it will be necessary.

@marcelstoer
Copy link
Contributor Author

marcelstoer commented Aug 21, 2024

Thanks a lot @serg3295 for your efforts!

  • dependencies are not updated

I guess that's fine. The dependabot in this project had previously opened a pile of PRs to get this fixed (still open).

@AndiDittrich
Copy link
Owner

thanks, just two question (comments) regarding backward compat

@serg3295
Copy link
Contributor

@AndiDittrich

I updated all dependencies and opened two PRs.
First PR updates dependencies without breaking changes
Second one has a breaking change as glob requires node >= 20

You can simply drop these PRs if they don't make sense or break backward compatibility.

@marcelstoer
Copy link
Contributor Author

Thanks @serg3295, looks sensible. So, a pragmatic way forward could be to merge the first PR and release this as 3.x, and then merge the 2nd.

@serg3295
Copy link
Contributor

Perhaps. However, there is not much difference between node18 (for serialport) and node20 (for glob). It is a breaking change anyway.

@AndiDittrich
Copy link
Owner

nodejs 18 ist required for current debian stable

@serg3295
Copy link
Contributor

Well, then the glob can be updated in a year :-)

@serg3295
Copy link
Contributor

I changed glob version to 10.4.4 that runs on node18 and force pushed the second PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants