Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#167455129 fix incident assignment #208

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

#167455129 fix incident assignment #208

wants to merge 1 commit into from

Conversation

intyro
Copy link
Collaborator

@intyro intyro commented Aug 1, 2019

What does this PR do?

fix to when you assign a user to an incident on the text box it is not saved, the assignment does not persist.

How should this be manually tested?

  1. Navigate to the incident timeline page.
  2. Assign a user to the incident.
  3. Make sure both assigned and CC'ed users are all in place.

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

167455129

Screenshots (if appropriate)

N/A

@TheSteelGuy
Copy link
Collaborator

Kindly rebase against developing to update this branch

@intyro intyro force-pushed the bg-fix-incident-assignment-167455130 branch from dc03296 to 4148e96 Compare August 7, 2019 15:08
@intyro intyro added the Ready Ready for review and merging label Aug 9, 2019
@intyro intyro requested review from kwameasiago and Paulvitalis200 and removed request for jideajayi11 and tejiri4 August 20, 2019 11:57
kwameasiago
kwameasiago approved these changes Aug 20, 2019
View reviewed changes
Copy link
Collaborator

@kwameasiago kwameasiago left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve the coverage other than that good job

@charitymarani charitymarani force-pushed the bg-fix-incident-assignment-167455130 branch 2 times, most recently from 1cddb3b to 6843398 Compare August 23, 2019 07:43
Paulvitalis200
Paulvitalis200 approved these changes Aug 27, 2019
View reviewed changes
Copy link
Collaborator

@Paulvitalis200 Paulvitalis200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this

@charitymarani charitymarani force-pushed the bg-fix-incident-assignment-167455130 branch from 6843398 to 987a643 Compare September 4, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paulvitalis200 Paulvitalis200 Paulvitalis200 approved these changes

@kwameasiago kwameasiago kwameasiago approved these changes

Assignees
No one assigned
Labels
Ready Ready for review and merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@intyro @TheSteelGuy @Paulvitalis200 @kwameasiago