-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSC: port #7
Comments
Did the first changes to have the MorphOS changes being applied to AmigaOS port as well |
Right now we are in a position where the JSC compiles but we get a lot of "undefined references" from the linker. Some of them are:
A full list of all the errors can be found at |
@walkero-gr For the ICU I see that: |
ubrk* functions should be from ICU lib too. So most probably you have an old (or too new) version of icu |
@3246251196 @afxgroup Thank you for your replies. I have an idea of what I possibly did wrong. I will work on it to be fixed. |
@3246251196 @afxgroup I did a few changes with my last commit at f301583
It seems that this refers to the following method at https://github.com/walkero-gr/webkitty/blob/amigaos_2.36.8/Source/WTF/wtf/morphos/MemoryPressureHandlerMorphOS.cpp#L43 Any thoughts on if we need it and if we have something similar for OS4? |
@walkero-gr |
Some more info on the problem with the I created the PlatformAmigaOS.cmake file like the one MorphOS has at https://github.com/walkero-gr/webkitty/blob/amigaos_2.36.8/Source/WTF/wtf/PlatformMorphOS.cmake This file includes the morphos files since those files could be common without specific changes for the AmigaOS 4. When I compile the JSCore with By searching deeper I found that if I go to But for me, this doesn't seem right, and if I understand correctly, the So I went and discussed that with Jacek and he told me the following:
So, as much as I understand we actually need to add the necessary files in So, what I plan to do in the following days is to do these changes and move on with the project and see how far it gets. For now, I know that it looks for AvailMem() which seems to not exist, so I need to figure this out. Will let you know how it goes. |
After the latest changes I did at https://github.com/walkero-gr/webkitty/pull/11 to overcome the above issue, there compilation continued until it stopped with the following complain.
Talking with @afxgroup he told me that libdl should not be used with his clib2 that we use. So I tried to find a way to overcome this issue. Unfortunately, I couldn't figure out how to remove the linking to libdl, but I saw at the Makefile that Jacek has a rule named Dummy/libdummy.a (https://github.com/walkero-gr/webkitty/blob/amigaos_2.36.8/Makefile#L212). This is used in other rules as well, where the full WebKit compilation is done. So, I did there the necessary changes and created a dummy libdl which I copied in the local/clib2/lib/ inside the SDK. That fixed the issues, until the next one which is the following:
Unfortunately, the new clib2 misses the dprintf() which is required at this point (AmigaLabs/clib4#76). |
Thanks to @3246251196 who added Running some of the test binaries, most complain that the JIT is not enabled, which is not going to be enabled for now. So we have t ignore them. But there is the Crashlog_pthread_id_1_2022-12-22_22-32-49.txt This needs to be investigated but before that I would like to see how it works with newlib. |
Started working with JSC and newlib. The compilation fails with the following methods missing Although mmap() can be ignored, the other two can not be skipped. I already informed newlib maintainer for ideas or for adding those methods in a newer version. |
Those pthread functions should probably get implemented in our own pthreads.library implementation, which is part of the SDK and can be found in the OS4 repository. If you were talking about Fredrick as the "newlib maintainer", then he would also be able to add those functions to pthreads.library. |
Added as much information for this work as possible at the wiki page |
JavaScriptCore (JSC) changes should be minimal
most features may be disabled (recommended). keep anything OFF in OptionsMorphOS as OFF. curl, cairo, hyphen, webp, harfbuzz should be OK to disable at this stage, drag support, content extensions off, whatever is disabled for MORPHOS_MINIMAL should be off
Log the process at repo wiki pages
The text was updated successfully, but these errors were encountered: