Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation for temperature and pressure #3

Open
4 tasks
mattdowdell opened this issue Aug 25, 2016 · 0 comments
Open
4 tasks

Validation for temperature and pressure #3

mattdowdell opened this issue Aug 25, 2016 · 0 comments

Comments

@mattdowdell
Copy link
Contributor

mattdowdell commented Aug 25, 2016

Temperature and pressure are currently validated to ensure they're numbers. Pressure is also checked to be greater than 0. This should be improved to set reasonable limits on their permitted range.

For temperature this could be the working range of the sensors +5(?)%. Pressure varies relatively little for what I would expect to be normal usage so it's just a matter of defining something sensible.

Once these limits have been implemented tests should be added to:

  • Test a number above the upper limit fails.
  • Test a number below the lower limit fails.
  • Test a number just above or at the lower limit passes.
  • Test a number just below or at the upper limit passes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant