Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uart_enable overrides cmdline.txt #1

Open
aapris opened this issue Mar 14, 2017 · 1 comment
Open

Uart_enable overrides cmdline.txt #1

aapris opened this issue Mar 14, 2017 · 1 comment

Comments

@aapris
Copy link

aapris commented Mar 14, 2017

Running Sensly installer replaces boot parameters in Raspi's cmdline.txt file while installer is runningUart_enable.sh.

This is bad, because cmdline may have custom modifications and removing them may make Raspi inaccessible.

A suggestion, instead:

  • parse existing cmdline parameters
  • remove only known parameters which are known to cause issues
  • add your own parameters
  • leave other parameters untouched
echo "dwc_otg.lpm_enable=0 console=tty1 root=/dev/mmcblk0p2 rootfstype=ext4 elevator=deadline fsck.repair=yes rootwait quiet splash plymouth.ignore-serial-consoles" >> /boot/cmdline.txt
sed -i -e '1s/^/#/' /boot/cmdline.txt

https://github.com/Altitude-Tech/Sensly_Install/blob/d1fe3bbe0dd4055a0a13e7c8399043a8ddae1b85/Uart_enable.sh#L5,L6

@aapris
Copy link
Author

aapris commented Mar 14, 2017

Or at least ask user before overriding cmdline, so user can manually modify parameters, if she/he wants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant