Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnalysisBrowser: Make it faster #2092

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

AnalysisBrowser: Make it faster #2092

wants to merge 4 commits into from

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Apr 19, 2024 •
edited
Loading

  • Make it fully resizable
  • Add checkboxes for loading TPStorage and Results waves (unchecked by default)
  • Add checkboxes for gathering NWB/PXP files separately, by default only NWB is checked
  • Default to collapse, collapse after NWB loading loading, keep collapsed in general
  • Skip loading labnotebook/results temp waves, this probably only needs to use the new recursive flag introduced in 2237ea3 (AB: Add optional recursive argument to AB_LoadDataWrapper, 2024-03-15)
  • Checkbox to load into the same sweepbrowser, defaults to false
  • Button to load /general/data_source as readonly notebook as that has the experiment history and logfiles.

t-b added 4 commits April 19, 2024 16:05
@t-b
AnalysisBrowser: Update the panel
4bddf98 
Make it fully resizable, replace the lines with groupboxes and add
checkboxes for selecting NWB/PXP files for loading and loading TPStorage
later on.
@t-b
AB_BrowserStartupSettings: Update it
4fc905e
@t-b
MIES_AnalysisBrowser.ipf: Rename AB_LoadType variable name
46a52ac 
We don't use underscores in variable names.
@t-b
changes
100c268
@t-b t-b self-assigned this Apr 19, 2024
@t-b t-b changed the title AnalysisBrowser: Update the panel AnalysisBrowser: Make it faster Apr 19, 2024
@MichaelHuth
Copy link
Collaborator

What bugs me in the AB is that the default behavior of Windows does not work for selecting.

Shift + MouseDown -> select all rows from the the last postition to the current one
Ctrl-A -> select all

@t-b
Copy link
Collaborator Author

t-b commented Apr 19, 2024 •
edited
Loading

@MichaelHuth I guess this is because IP is comming from a Mac.

@t-b t-b added the PR:Postponed 2025 Pull requests where we continue only in 2025 label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timjarsky timjarsky Awaiting requested review from timjarsky timjarsky will be requested when the pull request is marked ready for review timjarsky is a code owner

@MichaelHuth MichaelHuth Awaiting requested review from MichaelHuth MichaelHuth will be requested when the pull request is marked ready for review MichaelHuth is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@t-b t-b

Labels
PR:Postponed 2025 Pull requests where we continue only in 2025
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-b @MichaelHuth