Proposal: line number starts from ZERO for edit tool

[li-boxuan]

          I propose that line number starts from ZERO. Then we have `0 <= start <= end <= len(lines)`. When you have `end == len(lines)` you are basically appending.

Also, LSP uses zero-based line numbers.

Originally posted by @li-boxuan in #1941 (comment)

[renxida]

Is it more important to adhere to LSP conventions or error message conventions?

As far as I remember, As shown below, Python uses 1-based line numbers.

[li-boxuan]

As shown below, Python uses 1-based line numbers.

That's a good point. It's just a proposal and people should feel free to discuss pros & cons.

[tobitege]

IMHO 1-based line numbering is most natural and personally the primary way in code editors that I had to work with professionally since the late '90s.

[renxida]

maybe figure out whether 1 based or 0 based is more popular, and convert everything to the more popular convention

[tobitege]

It is not a matter of popularity. As you already pointed out in an earlier post, Python itself shows error indicators 1-based. Also Sphinx, the documentation tool for Python, uses 1-based line numbers.