AAE-23976 Fix not able to delete custom filter if the name is the sam… #9991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e as default filter
kathrine0
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
mauriziovitale
approved these changes
Jul 25, 2024
wiktord2000
reviewed
Jul 26, 2024
| @@ -6,12 +6,12 @@ | |||
| <mat-card-content class="adf-process-filter-dialog-card-content"> | |||
| <form [formGroup]="filterForm"> | |||
| <mat-form-field class="adf-process-filter-name" [floatLabel]="'auto'"> | |||
| <input matInput placeholder="{{ 'ADF_CLOUD_EDIT_PROCESS_FILTER.FILTER_NAME' | translate }}" formControlName="name" id="adf-filter-name-id"> | |||
| <input matInput placeholder="{{ 'ADF_CLOUD_EDIT_PROCESS_FILTER.FILTER_NAME' | translate }}" [formControl]="filterForm.controls.name" id="adf-filter-name-id"> | |||
There was a problem hiding this comment.
I will wrap filterForm.controls.name as a getter filterName, would be easier to understand but the change is up to you, approved
wiktord2000
approved these changes
Jul 26, 2024
…om-filter-if-name-is-the-same
…om-filter-if-name-is-the-same
…om-filter-if-name-is-the-same
|
kathrine0
deleted the
fix/AAE-23976-fix-not-able-to-delete-custom-filter-if-name-is-the-same
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e as default filter
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/AAE-23976
What is the new behaviour?
filters.duplicate.names.mov
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: