Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-24081 Fix refresh token error with multiple tabs opened #9964

Conversation

alep85
Copy link
Contributor

@alep85 alep85 commented Jul 19, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/AAE-24081

What is the new behaviour?
Token is refreshed properly when multiple tabs are opened

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@alep85 alep85 force-pushed the fix/AAE-24081-fe-refresh-token-error-with-multiple-tabs-opened branch from bcfbffb to b148dfa Compare July 19, 2024 14:45
Copy link
Contributor

@eromano eromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the case to add some unit test?

@alep85
Copy link
Contributor Author

alep85 commented Jul 23, 2024

Is it the case to add some unit test?

@eromano unit test added

@alep85 alep85 marked this pull request as ready for review July 23, 2024 13:26
@alep85 alep85 force-pushed the fix/AAE-24081-fe-refresh-token-error-with-multiple-tabs-opened branch from e8462b2 to 26d99cc Compare July 23, 2024 13:40
Copy link

sonarcloud bot commented Jul 23, 2024

@DenysVuika DenysVuika merged commit 4c8e53d into develop Jul 23, 2024
32 checks passed
@DenysVuika DenysVuika deleted the fix/AAE-24081-fe-refresh-token-error-with-multiple-tabs-opened branch July 23, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants